On Mon, Oct 29, 2012 at 08:42:18PM -0700, Ronald S. Bultje wrote: > On Mon, Oct 29, 2012 at 7:28 PM, Diego Biurrun <di...@biurrun.de> wrote: > > -%include "x86inc.asm" > > %include "x86util.asm" > > Didn't you come up with the rule that each file should contain all > headers it directly takes symbols from? How do these changes fit > with that scheme?
The attribution belongs to Mans and applies to C header files. But C header files are quite different beasts. One feature they have are multiple inclusion guards that safeguard against strange effects from macro redefinitions. The YASM helper files cannot be included multiple times and besides, my patch set changes the semantics of x86inc.asm from a generic helper file to one that works more like a template and where at least one macro value should be overridden. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel