On Sat, Nov 03, 2012 at 10:06:20PM +0100, Jordi Ortiz wrote: > These modifications are (imho) the minimal needed for dirac. > --- > libavcodec/dsputil.c | 8 ++++++++ > libavcodec/dsputil.h | 6 ++++++ > 2 files changed, 14 insertions(+)
Why is this comment part of the log message? Use --annotate and write your comments below the "---" so it does not become part of the log message. > diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c > index 7a3fdba..2e2bda9 100644 > --- a/libavcodec/dsputil.c > +++ b/libavcodec/dsputil.c > @@ -2921,6 +2921,14 @@ av_cold void ff_dsputil_init(DSPContext* c, > AVCodecContext *avctx) > c->add_pixels4 = FUNCC(add_pixels4 ## dct , depth);\ > c->put_no_rnd_pixels_l2[0] = FUNCC(put_no_rnd_pixels16_l2, depth);\ > c->put_no_rnd_pixels_l2[1] = FUNCC(put_no_rnd_pixels8_l2 , depth);\ > + c->put_pixels_l2[0] = put_pixels16_l2_8; \ > + c->put_pixels_l2[1] = put_pixels8_l2_8; \ > + c->avg_pixels_l2[0] = avg_pixels16_l2_8; \ > + c->avg_pixels_l2[1] = avg_pixels8_l2_8; \ > + c->put_pixels_l4[0] = put_pixels16_l4_8; \ > + c->put_pixels_l4[1] = put_pixels8_l4_8; \ > + c->avg_pixels_l4[0] = avg_pixels16_l4_8; \ > + c->avg_pixels_l4[1] = avg_pixels8_l4_8; \ Group the put_ and avg_ functions together and align the \. The patch is fine with me, but maybe some other person wants to comment on the dsputil integration. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel