Hi, On Thu, Nov 8, 2012 at 2:17 PM, Justin Ruggles <justin.rugg...@gmail.com>wrote:
> On 10/29/2012 04:39 PM, Justin Ruggles wrote: > > From: Ronald S. Bultje <rsbul...@gmail.com> > > > > Fixes crashes on Win32 and stack overruns on x86-32 in general. > > --- > > libavresample/x86/audio_mix.asm | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/libavresample/x86/audio_mix.asm > b/libavresample/x86/audio_mix.asm > > index 0c4a9bd..cdc787d 100644 > > --- a/libavresample/x86/audio_mix.asm > > +++ b/libavresample/x86/audio_mix.asm > > @@ -280,6 +280,13 @@ cglobal mix_%1_to_%2_%3_flt, > 3,in_channels+2,needed_mmregs+matrix_elements_mm, s > > sub rsp, matrix_elements_stack * mmsize > > %else > > %assign pad matrix_elements_stack * mmsize + (mmsize - gprsize) - > (stack_offset & (mmsize - gprsize)) > > + ; on x86-32 for 7 and 8 channels we need more stack space for src > pointers > > + %if ARCH_X86_32 && in_channels >= 7 > > + %assign pad pad + 0x10 > > + %define src5m [rsp+0xc0] > > + %define src6m [rsp+0xc4] > > + %define src7m [rsp+0xc8] > > + %endif > > SUB rsp, pad > > %endif > > %endif > > ping Well it's my patch and you reviewed it, isn't that enough? Ronald
_______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
