On Wed, Nov 14, 2012 at 05:28:53PM -0500, Justin Ruggles wrote: > On 11/14/2012 04:16 PM, Diego Biurrun wrote: > > --- a/libavutil/x86/x86util.asm > > +++ b/libavutil/x86/x86util.asm > > @@ -599,25 +599,37 @@ > > > > -%macro PMINSD_MMX 3 ; dst, src, tmp > > +%macro PMINSD 3 ; dst, src, tmp/unused > > +%if mmsize == 8 > > mova %3, %2 > > pcmpgtd %3, %1 > > pxor %1, %2 > > pand %1, %3 > > pxor %1, %2 > > +%elif cpuflag(sse4) > > + pminsd %1, %2 > > +%elif cpuflag(sse2) > > + cvtdq2ps %1, %1 > > + minps %1, %2 > > + cvtps2dq %1, %1 > > +%endif > > %endmacro > > It needs to be clearly documented that, for the sse2 versions, src is > float not dword.
Does it make sense to keep it in the same macro then? I also notice that you sent a patch port PMINSD/PMAXSD to cpuflags some time ago, but it was never applied ... Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
