Justin Ruggles <justin.rugg...@gmail.com> writes:
> +static inline uint64_t get_bits_longlong(GetBitContext *s, int n)
That is a stupid name. Call it get_bits64() or something instead.
> +{
> + if (n <= 32) {
> + return get_bits_long(s, n);
> + } else {
> +#ifdef BITSTREAM_READER_LE
> + uint64_t ret = get_bits_long(s, 32);
> + return ret | (((uint64_t)get_bits_long(s, n-32)) << 32);
Lots of useless ().
> +#else
> + uint64_t ret = ((uint64_t)get_bits_long(s, 32)) << (n-32);
Almost as many useless ().
> + return ret | get_bits_long(s, n-32);
> +#endif
> + }
> +}
--
Måns Rullgård
m...@mansr.com
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
