Hi, On Fri, Dec 7, 2012 at 2:08 PM, Måns Rullgård <m...@mansr.com> wrote: > "Ronald S. Bultje" <rsbul...@gmail.com> writes: > >> Hi, >> >> On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård <m...@mansr.com> wrote: >>> "Ronald S. Bultje" <rsbul...@gmail.com> writes: >>>> On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård <m...@mansr.com> wrote: >>>>> "Ronald S. Bultje" <rsbul...@gmail.com> writes: >>>>> >>>>>> + %if mmsize <= 16 && HAVE_ALIGNED_STACK >>>>> >>>>> How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? >>>> >>>> Well, for now, we still have a ton of functions that don't use the >>>> cglobal-method of allocating stack. I only ported h264/vp8 loopfilter, >>>> nothing else. >>>> >>>> But anyway, more generally, it's 4-5 instructions per function. For >>>> typical functions with an inner loop, that's negligible, but for a >>>> select small set of functions, it may be significant. >>> >>> The remaining functions are ff_h264_idct8_add(4)_10_{sse2,avx}, >>> ff_hadamard8_diff(16)_{sse2,ssse3}, and something in swscale. >> >> lavr also. > > There are no references to HAVE_ALIGNED_STACK there.
It crashes on x86-32 icc10.x and msvc. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel