Diego Biurrun <di...@biurrun.de> writes: > On Sat, Nov 17, 2012 at 10:33:27AM -0500, Justin Ruggles wrote: >> >> --- a/libavcodec/ac3dsp.c >> +++ b/libavcodec/ac3dsp.c >> @@ -24,6 +24,10 @@ >> #include "ac3.h" >> #include "ac3dsp.h" >> >> +#if ARCH_X86 >> +#include "x86/ac3dsp.h" >> +#endif >> + >> --- /dev/null >> +++ b/libavcodec/x86/ac3dsp.h >> @@ -0,0 +1,28 @@ >> + >> +#ifndef AVCODEC_X86_AC3DSP_H >> +#define AVCODEC_X86_AC3DSP_H >> + >> +#include "libavcodec/ac3dsp.h" >> + >> +void ff_ac3dsp_set_downmix_x86(AC3DSPContext *c); >> + >> +#endif /* AVCODEC_X86_AC3DSP_H */ > > The #ifdef around the #include is unnecessary, the header is completely > harmless and can be #included anywhere.
Simpler still, put that lone prototype directly in libavcodec/ac3dsp.h like we do for all other functions like this. -- Måns Rullgård m...@mansr.com _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
