On 12/10/2012 04:28 PM, Jindřich Makovička wrote: > On Mon, Dec 10, 2012 at 3:07 PM, Diego Biurrun <di...@biurrun.de> wrote: >> On Mon, Dec 10, 2012 at 02:48:28PM +0100, Jindřich Makovička wrote: >>> >>> Some files contain a few additional, all-0 bits. >>> Check for that case and don't print incorrect "not supported" >>> message. >>> Fixes trac issue #836. >> >> We don't use trac. > > fixed by removing. > >>> --- a/libavcodec/aacsbr.c >>> +++ b/libavcodec/aacsbr.c >>> @@ -926,7 +926,9 @@ static void read_sbr_extension(AACContext *ac, >>> SpectralBandReplication *sbr, >>> default: >>> - av_log_missing_feature(ac->avctx, "Reserved SBR extensions", 1); >>> + // some files contain 0-padding >>> + if (bs_extension_id || *num_bits_left > 16 || show_bits(gb, >>> *num_bits_left)) >>> + av_log_missing_feature(ac->avctx, "Reserved SBR extensions >>> are", 1); >> >> Adding the verb is wrong, av_log_missing_feature() already takes care >> of that. > > ... and I wondered why the original patch didn't apply to libav. > > Fixed patch attached.
Looks ok, I assume 16 is the maximum padding, could be nice set it as a macro to have it self explaining. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
