Hi, On Thu, Jan 17, 2013 at 7:35 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Thu, Jan 17, 2013 at 07:09:02AM -0800, Ronald S. Bultje wrote: >> On Thu, Jan 17, 2013 at 1:45 AM, Diego Biurrun <di...@biurrun.de> wrote: >> > --- >> > >> > This is a quick idea I had to give Daniel another small, separate piece >> > of dsputil inline assembly to work on w/o having to fiddle with the C >> > code. The vp3dsp_template ugliness will go away the moment this is >> > converted to yasm , which should be really soon. >> > >> > Passes all tests on x86_64 and x86_32, will compile-test on ppc and arm >> > later. >> > >> > libavcodec/arm/vp3dsp_init_arm.c | 2 +- >> > libavcodec/ppc/vp3dsp_altivec.c | 2 +- >> > libavcodec/vp3.c | 2 +- >> > libavcodec/vp3dsp.c | 8 +- >> > libavcodec/vp3dsp.h | 8 +- >> > libavcodec/vp56.c | 2 +- >> > libavcodec/x86/dsputil_avg_template.c | 81 ------------------------ >> > libavcodec/x86/dsputil_mmx.c | 11 --- >> > libavcodec/x86/vp3dsp_init.c | 34 ++++++++++- >> > libavcodec/x86/vp3dsp_template.c | 109 >> > +++++++++++++++++++++++++++++++++ >> > 10 files changed, 154 insertions(+), 105 deletions(-) >> > create mode 100644 libavcodec/x86/vp3dsp_template.c >> > >> > --- a/libavcodec/arm/vp3dsp_init_arm.c >> > +++ b/libavcodec/arm/vp3dsp_init_arm.c >> > @@ -30,7 +30,7 @@ void ff_vp3_idct_dc_add_neon(uint8_t *dest, int >> > line_size, const DCTELEM *data); >> > >> > -av_cold void ff_vp3dsp_init_arm(VP3DSPContext *c, int flags) >> > +av_cold void ff_vp3dsp_init_arm(VP3DSPContext *c, int flags, DSPContext >> > *dsp) >> >> Why? You want to make vp3dsp depend on dsputil? Please no. > > VP3 depends on dsputil already as it uses put_no_rnd_pixels_tab and > put_no_rnd_pixels_l2 and put_pixels_tab and a few other things. No > new dependency is added. This is modeled after rv30dsp/rv40dsp.
No. Rejected. Absolutely not. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
