On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: > On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun <di...@biurrun.de> wrote: > > On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: > >> On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun <di...@biurrun.de> wrote: > >> > It does not help as an abstraction and adds dsputil dependencies. > >> > >> I like the commit. I do want to add, though, that you're not actually > >> practically removing the dsputil dependency from a lot of files (at > >> build time), even though the dependency is (in a code-sense) no longer > >> there. Examples are in vp3.c or vp8.c, but there's likely more. > > > > Your comment puzzles me. vp3.c directly uses DSPContext, vp8.c has no > > dependency on dsputil, before or after my patch ... > [..blah..] > > $ grep dsputil\.h ../libavcodec/vp*dsp.h > ../libavcodec/vp3dsp.h:#include "dsputil.h" > ../libavcodec/vp8dsp.h:#include "dsputil.h"
So it's a game of showing shell output; here's mine: $ grep dsputil\.h libavcodec/vp*dsp.h libavcodec/vp3dsp.h:#include "dsputil.h" libavcodec/vp8dsp.h:#include "dsputil.h" $ git cherry-pick c2567e6c6771a6a5bd66762e486eae0cd608f7a4 Finished one cherry-pick. [test a10ebd3] Drop DCTELEM typedef 163 files changed, 835 insertions(+), 812 deletions(-) $ grep dsputil\.h libavcodec/vp*dsp.h $ git log -n 1 --oneline c2567e6c6771a6a5bd66762e486eae0cd608f7a4 | cat c2567e6 Drop DCTELEM typedef Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
