On 02/06/2013 12:40 AM, Diego Biurrun wrote:
@@ -100,48 +100,73 @@ static const AVClass asf_class = {
  // Fix Me! FRAME_HEADER_SIZE may be different.

  static const ff_asf_guid index_guid = {
-    0x90, 0x08, 0x00, 0x33, 0xb1, 0xe5, 0xcf, 0x11, 0x89, 0xf4, 0x00, 0xa0, 
0xc9, 0x03, 0x49, 0xcb
+    0x90, 0x08, 0x00, 0x33, 0xb1, 0xe5, 0xcf, 0x11,
+    0x89, 0xf4, 0x00, 0xa0, 0xc9, 0x03, 0x49, 0xcb
  };

please do not break GUIDs

  #ifdef DEBUG
  static const ff_asf_guid stream_bitrate_guid = { /* (http://get.to/sdp) */
-    0xce, 0x75, 0xf8, 0x7b, 0x8d, 0x46, 0xd1, 0x11, 0x8d, 0x82, 0x00, 0x60, 
0x97, 0xc9, 0xa2, 0xb2
+    0xce, 0x75, 0xf8, 0x7b, 0x8d, 0x46, 0xd1, 0x11,
+    0x8d, 0x82, 0x00, 0x60, 0x97, 0xc9, 0xa2, 0xb2
  };

dito

-    else PRINT_IF_GUID(g, ff_asf_metadata_header);
-    else PRINT_IF_GUID(g, ff_asf_marker_header);
-    else PRINT_IF_GUID(g, stream_bitrate_guid);
-    else PRINT_IF_GUID(g, ff_asf_language_guid);
+    else
+        PRINT_IF_GUID(g, ff_asf_file_header);
+    else
+        PRINT_IF_GUID(g, ff_asf_stream_header);
+    else
+        PRINT_IF_GUID(g, ff_asf_audio_stream);

don't see the point of blowing that up 2x...

....

rest looks ok in terms of formatting, anything is better than the existing mess. I did not compare it line by line though.

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to