On Fri, Mar 01, 2013 at 09:35:24PM +0100, Anton Khirnov wrote: > > On Fri, 01 Mar 2013 20:59:21 +0100, Diego Biurrun <[email protected]> wrote: > > On Fri, Mar 01, 2013 at 08:50:31PM +0100, Anton Khirnov wrote: > > > On Thu, 28 Feb 2013 21:25:01 +0100, Diego Biurrun <[email protected]> > > > wrote: > > > > --- a/libavcodec/internal.h > > > > +++ b/libavcodec/internal.h > > > > @@ -67,7 +68,7 @@ typedef struct AVCodecInternal { > > > > * Internal sample count used by avcodec_encode_audio() to > > > > fabricate pts. > > > > * Can be removed along with avcodec_encode_audio(). > > > > */ > > > > - int sample_count; > > > > + attribute_deprecated int sample_count; > > > > #endif > > > > > > Internal API -> no point > > > > Why? Devs can still go ahead and misuse deprecated API w/o noticing. > > The warnings are supposed to prevent that ... > > Since they are private, the only reason they are kept is that they still have > some use. So you will add spurious warnings.
Well, yes, that's the whole point: Add warnings for each use. That might motivate people to fix the warnings and deter new uses of deprecated functionality being introduced. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
