On Sat, Mar 2, 2013 at 5:57 PM, Diego Biurrun <[email protected]> wrote:
> On Fri, Mar 01, 2013 at 01:38:33PM -0800, Dave Yeo wrote: > > On 03/01/13 09:56 am, Luca Barbato wrote: > > >On 01/03/13 18:53, Vittorio Giovara wrote: > > >>Resend without the unnecessary change. > > > > > >I'm wondering if we couldn't just drop the support for older sdl and > > >just rely on pkg-config. > > > > Nothing against the patch but I will point out that not all SDL > > ports install a pkg-config file (or a sdl-config). eg the OS/2 port > > is compiled with OpenWatcom and a wmake file instead of the usual > > configure && make using GCC. > > Documentation for fixing SDL to make it configure and GCC friendly > > are at http://www.edm2.com/index.php/SDL > > But that means that we currently have no SDL support for OS/2 anyway > as we rely on pkg-config to detect SDL. > > > Well maybe OS/2 doesn't suffer from the linking main() problem, so the old test could be kept. Extending this idea, if the main() problem happens on mingw only, why not using the current test code for all platforms but mingw and explicit the test with the proposed code for mingw only? Alternatively, one could substitute the main(void) declaration with main(int argc, char *argv[]) in the check_* code and leave the test sdl section as it is, but I've heard that was not going to be a popular idea (as it may break other things, although not sure which ones). Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
