On 2013-03-04 11:26:52 +0100, Luca Barbato wrote: > The decoder assumes a single bitdepth for all the planes, the > specification does allow that. > > Avoid the possible problems pointed in CVE-2013-2277 > > CC: [email protected] > --- > libavcodec/h264.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c > index a20a6f7..15fabee 100644 > --- a/libavcodec/h264.c > +++ b/libavcodec/h264.c > @@ -2756,6 +2756,11 @@ static int h264_set_parameter_from_sps(H264Context *h) > "VDPAU decoding does not support video colorspace.\n"); > return AVERROR_INVALIDDATA; > } > + if (h->sps.bit_depth_luma != sps->bit_depth_chroma) {
this is not a good place to put the check. move it out of this if block so it's always checked and not only if luma bit depth or the chroma format changes. > + av_log_missing_feature(h->avctx, > + "Different bitdepth between chroma and luma", 1); bit depth > + return AVERROR_PATCHWELCOME; Not sure about that ;) Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
