On Thu, Mar 7, 2013 at 7:26 AM, Anton Khirnov <[email protected]> wrote:
>
> On Wed, 06 Mar 2013 00:55:47 +0100, Diego Biurrun <[email protected]> wrote:
>> On Tue, Mar 05, 2013 at 08:01:20AM +0100, Anton Khirnov wrote:
>> > On Mon, 04 Mar 2013 23:17:09 +0100, Diego Biurrun <[email protected]> wrote:
>> > > On Mon, Mar 04, 2013 at 11:35:05AM +0100, Anton Khirnov wrote:
>> > > > --- /dev/null
>> > > > +++ b/libavutil/buffer.h
>> > > > @@ -0,0 +1,195 @@
>> > > > +
>> > > > + * There are two core objects in this API -- AVBuffer and
>> > > > AVBufferRef. AVBuffer
>> > > > + * represents the data buffer itself; it is opaque and not meant to
>> > > > be accessed
>> > > > + * by the caller directly, but only through AVBufferRef. However, the
>> > > > caller may
>> > > > + * e.g. compare two AVBuffer pointers to check whether two different
>> > > > references
>> > > > + * are describing the same data buffer (note that the two references
>> > > > may point
>> > > > + * to different parts of the buffer, so comparing the data pointers
>> > > > will not
>> > > > + * work).
>> > >
>> > > I am now thoroughly confused why you suggest comparing two pointers and
>> > > then go on to explain why comparing two pointers may fail...
>> >
>> > I'm suggesting to compare AVBuffer pointers.
>> >
>> > What can fail is comparing data pointers.
>> >
>> > Those are different things.
>>
>> You first speak of "two AVBuffer pointers describing data buffers" and
>> the "two data pointers" are not the same pointers you mentioned first?
>> Please clarify what exactly the "data pointers" are in that case.
>>
>
> A "data pointer" is a pointer to data. An "AVBuffer pointer" is a pointer to
> AVBuffer.
>
> The first one is accessed as AVBufferRef.data. The second one is
> AVBufferRef.buffer.
>
> Is that really so unclear?
TBH, without the explanation you have provided, I was similarly
confused as Diego. With that explanation, the text above is much
clearer. I would suggest to add the note not as side remark in
brackets, but to start a new paragraph with "NB:", and elaborate, e.g.
using "direct pointers to the data" instead of "data pointers" (all
are data pointers after all).
--
regards,
Reinhard
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
