On 13/03/13 13:09, Vittorio Giovara wrote:
> ---
>  libavcodec/avcodec.h    |    3 +++
>  libavcodec/options.c    |    2 ++
>  libavutil/Makefile      |    2 ++
>  libavutil/stereoscopy.c |   11 +++++++++++
>  libavutil/stereoscopy.h |   29 +++++++++++++++++++++++++++++
>  5 files changed, 47 insertions(+)
>  create mode 100644 libavutil/stereoscopy.c
>  create mode 100644 libavutil/stereoscopy.h
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index e48b114..9cc1976 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -36,6 +36,7 @@
>  #include "libavutil/log.h"
>  #include "libavutil/pixfmt.h"
>  #include "libavutil/rational.h"
> +#include "libavutil/stereoscopy.h"
>  
>  #include "libavcodec/version.h"
>  /**
> @@ -2624,6 +2625,8 @@ typedef struct AVCodecContext {
>       * - decoding: unused.
>       */
>      uint64_t vbv_delay;
> +
> +    AVStereo stereo_info;
>  } AVCodecContext;

Doesn't look the right place as mentioned before. It look like a
container information.

> diff --git a/libavutil/stereoscopy.c b/libavutil/stereoscopy.c
> new file mode 100644
> index 0000000..10dc810

License header missing

> --- /dev/null
> +++ b/libavutil/stereoscopy.c
> @@ -0,0 +1,11 @@
> +
> +#include "stereoscopy.h"
> +
> +
> +void avstereo_init(AVStereo *s)
> +{
> +    s->type = STEREO_NONE;
> +    s->order = ORDER_NA;
> +    s->fullsize = 0;
> +}

while at it align the "="

> +
> diff --git a/libavutil/stereoscopy.h b/libavutil/stereoscopy.h
> new file mode 100644
> index 0000000..f49d5ac
> --- /dev/null
> +++ b/libavutil/stereoscopy.h
> @@ -0,0 +1,29 @@

License header missing.

> +#include "libavutil/avutil.h"
> +
> +
> +enum stereoType {
> +    STEREO_NONE,
> +    STEREO_ANAGLYPH,
> +    STEREO_FRAMESEQUENCE,
> +    STEREO_SIDEBYSIDE,
> +    STEREO_TOPBOTTOM,
> +    STEREO_CHECKERS,
> +    STEREO_LINES,
> +    STEREO_COLUMNS,
> +};
> +
> +enum stereoOrder {
> +    ORDER_NA,
> +    ORDER_LR,
> +    ORDER_RL,
> +};
> +
> +typedef struct AVStereo {
> +    enum stereoType type;
> +    enum stereoOrder order;
> +    int fullsize;
> +} AVStereo;
> +
> +
> +void avstereo_init(AVStereo *s);

Not sure about the init function, it is equivalent to a memset. it could
be dropped probably.

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to