On Wed, Mar 27, 2013 at 11:50:57AM +0200, Martin Storsjö wrote: > On Tue, 26 Mar 2013, Diego Biurrun wrote: > > >On Tue, Mar 26, 2013 at 06:26:37PM +0200, Martin Storsjö wrote: > >>This makes standalone compilation of the eamad and eatqi decoders > >>and mpeg1video and mpeg2video encoders succeed. The dependency > >>comes from the shared mpeg12.o file. > >> > >>--- > >>Splitting out the pieces from mpeg12.c that is shared for each > >>of these components, which doesn't use ER, isn't all that > >>trivial - patches welcome though. > > > >I have split (most of) the mpeg12 decoder code from the shared code. > >That obviates adding ER to the eamad decoder dependencies.
As well as to the mpeg1video and mpeg2video encoders, so only eatqi is left with incomplete dependencies now. I'm unsure if it is preferable to try to separate ff_mpeg1_decode_block_intra() from the rest of the mpeg12 decoder code or just add the ER deps to eatqi. > >Would adding a bunch of ER ifdefs work alternatively? > > Yes, probably, but I'm not sure of the right scope for them. We can > easily ifdef out each call to ER functions within this file, but > that feels a bit ugly. If you find some bigger piece of code that > can be disabled for these configurations, it'd be even better. Nah, littering that code with ifdefs does not sound very appealing. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
