On 26/03/13 10:24, Luca Barbato wrote:
> On 25/03/13 23:53, Diego Biurrun wrote:
>> On Fri, Mar 22, 2013 at 11:35:23AM +0100, Luca Barbato wrote:
>>> --- a/tests/fate-run.sh
>>> +++ b/tests/fate-run.sh
>>> @@ -189,5 +190,11 @@ fi
>>>  
>>> +if test $err != 0 && test $gen != "no" ; then
>>> +    echo "GEN     $ref"
>>> +    cp "$outfile" "$ref"
>>> +    err=$?
>>> +fi
>>> +
>>>  test $err = 0 && rm -f $outfile $errfile $cmpfile $cleanfiles
>>>  exit $err
>>
>> Why do you override the return value here?
>>
> 
> If cp fails you report the failure.
> 

Is this patch good to go or not?

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to