On 04/19/2013 09:48 AM, Anton Khirnov wrote: > > On Wed, 17 Apr 2013 12:35:46 +0200, Luca Barbato <[email protected]> wrote: >> On 04/17/2013 12:19 PM, Anton Khirnov wrote: >>>> +#define AVFMT_TS_NEGATIVE 0x40000 /**< Format allows muxing negative >>>> + timestamps. If not set the >>>> timestamp >>>> + will be shifted in av_write_frame >>>> and >>>> + av_interleaved_write_frame so they >>>> + start from 0. */ >>>> >>> >>> Nit, I'd put this above the #define >> >> I'd do later reformatting all the others as well. >> >>> This would be safer with some checks for AV_NOPTS_VALUE >> >> The callers should already check and let it through only if >> AVFMT_NOTIMESTAMPS is set. >> > > The check in av_interleaved_write_frame() applies only to dts, not pts.
compute_pkt_fields2 should contain the check. > And there is no check at all for av_write_frame(). Yup, in theory you are supposed to feed valid timestamps, better be safe than sorry. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
