On 05/25/2013 12:01 PM, Alex Smith wrote:
> From: Laurent <laurent....@gmail.com>
> 
> Change the check_exec_crash test to use a function pointer instead of
> simply calling the function.  The EBP availability test will crash when
> compiled with ICL likely due to compiler optimization shenanigans.
> 
> Originally the check_exec_crash code was moved out of main to fix a
> problem with gcc's treatment of non-leaf main on x86_32.  libav already
> moved the code out of main but the addition of the function pointer will
> prevent any inlining which fixes the remaining problem.
> 
> A function pointer is used since it is compiler agnostic (as opposed to
> say __attribute__ ((noinline)) which would only work with gcc compatible
> compilers).
> 

Looks fine, thanks for the explanation.

lu

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to