On 06/27/2013 02:54 PM, Diego Biurrun wrote:
> On Thu, Jun 27, 2013 at 01:22:41AM +0200, Luca Barbato wrote:
>> --- a/libavcodec/aacdec.c
>> +++ b/libavcodec/aacdec.c
>> @@ -527,9 +556,12 @@ static ChannelElement *get_che(AACContext *ac, int
>> type, int elem_id)
>> case 6:
>> - /* Some streams incorrectly code 5.1 audio as SCE[0] CPE[0] CPE[1]
>> SCE[1]
>> - instead of SCE[0] CPE[0] CPE[1] LFE[0]. If we seem to have
>> - encountered such a stream, transfer the LFE[0] element to the
>> SCE[1]'s mapping */
>> + /* Some streams incorrectly code 5.1 audio as
>> + * SCE[0] CPE[0] CPE[1] SCE[1]
>> + * instead of
>> + * SCE[0] CPE[0] CPE[1] LFE[0].
>> + * If we seem to have encountered such a stream, transfer
>> + * the LFE[0] element to the SCE[1]'s mapping */
>> if (ac->tags_mapped == tags_per_config[ac->oc[1].m4ac.chan_config]
>> - 1 && (type == TYPE_LFE || type == TYPE_SCE)) {
>
> The following is better IMO even if it slightly exceeds 80 chars:
>
> if (ac->tags_mapped == tags_per_config[ac->oc[1].m4ac.chan_config] - 1
> &&
> (type == TYPE_LFE || type == TYPE_SCE)) {
>
> LGTM anyway
Once I feel inclined I might try and refactor this in a saner way (e.g.
not having to carry aroundac->oc[1].m4ac.chan_config and such).
For now let's improve a little what we have.
lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
