On Thu, Jun 27, 2013 at 02:56:03PM +0200, Luca Barbato wrote: > On 06/27/2013 02:48 PM, Diego Biurrun wrote: > > On 2013-06-27 12:35, Nicolas BERTRAND wrote: > >> Le 24/06/2013 19:21, Diego Biurrun a écrit : > >>> On 2013-06-24 17:14, Luca Barbato wrote: > >>>> From: Michael Niedermayer <michae...@gmx.at> > >>>> > >>>> Split stepsize and data in int and float variants. > >>>> > >>>> Spare a good number of casts and make simple spot errors. > >>> > >>> There is no such word as "make simple", it's "simplify", so > >>> "simplify spotting errors". > >>> > >>> I still believe a union is the proper solution here. > >> Not sure it helps a lot on readability. > > > > AFAICS one would have data.i and data.f (or similar) instead of > > i_data and f_data, but the data structure would resemble the intent > > more closely, avoid all the casting and also have no holes. > > I'd complete the codebase and then split the float and int codepaths > cleanly (as done with audio). > > For now I doubt Nicolas has the interest in doing that now and I do not > see anybody else with the time or will.
Ask me in a month or so. Until then, whatever ... Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
