On Thu, 11 Jul 2013, Diego Biurrun wrote:

Check for support of ..?

I'd say 'support for' is just as correct, so I'm keeping it like this. (I also checked a few dictionaries and didn't found anything telling me otherwise.)


On 2013-07-11 16:23, Martin Storsjö wrote:
--- a/configure
+++ b/configure
@@ -3405,6 +3406,8 @@ unsigned int endian = 'B' << 24 | 'I' << 16 | 'G' << 8 | 'E';
  EOF
  od -t x1 $TMPO | grep -q '42 *49 *47 *45' && enable bigendian

+check_inline_asm inline_asm_labels '"1:\n"'
+
  if enabled alpha; then

      check_cflags -mieee

I guess this is more general than just AIX PPC, but AIX PPC is the only affected platform AFAIU. I'm somewhat undecided if we shouldn't restrict this to PPC then.

Well, labels in inline assembly is something that is supported on most/all platforms that gas/gcc supports, afaik. And if we have the HAVE_INLINE_ASM_LABELS item, it would feel weird to have it set to 0 on most platforms except PPC. So I'd rather keep the check generic.

Would there be any point to putting this behind a "enabled inline_asm && ..."? I don't think doing this check would hurt even if the compiler doesn't support inline asm. (It doesn't hurt for MSVC.)

Patch looks good otherwise and is probably OK as-is.

Ok, good.

// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to