On 2013-07-11 20:57, Martin Storsjö wrote:
On Tue, 28 May 2013, Diego Biurrun wrote:
On 2013-05-27 00:18, Martin Storsjö wrote:
On Mon, 27 May 2013, Martin Storsjö wrote:
From: Diego Biurrun <di...@biurrun.de>
During each make run, the build system checks that any specified
dependencies
do actually exist, to prevent typos and other errors from fouling up
correct
dependency settings. However, it also causes make to trip up when new
components have been added to the code, but not yet registered in the
build
system by configure. A manual configure call is required in this case.
The "config" target is designed precisely to reinitialize the build
without
having to manually call configure. Skip the dependency check when
running
the "config" target to allow automatic reconfiguration in such cases.
Also skip the dependency check when doing clean, distclean and
fate-rsync.
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -20,7 +20,11 @@ tests/data/vsynth2.yuv: tests/rotozoom$(HOSTEXESUF)
+# Do not check existence of config variables when reconfiguring to
allow new
+# config variables getting registered in the build system.
+ifneq ($(filter clean config distclean fate-rsync, $(MAKECMDGOALS)),
$(MAKECMDGOALS))
CHKCFG = $(if $($(1))$(!$(1)),$($(1)), $(error No such config: $(1)))
+endif
Another less backwards way of writing this probably would be
ifneq ($(filter-out clean config distclean fate-rsync,
$(MAKECMDGOALS)), )
I can amend it to that if you prefer that version.
I think both versions are too brittle. You already missed testclean
from that list. I'll try to cook something up that only applies to
fate- targets later.
Given that there's still no better solution, and this still is an issue
I run into every now and then, I'd still like to get a version of this
included - until a better solution appears obviously. I can resubmit a
new version of the patch with testclean included.
Please ping me about this sometime next week.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
