On Wed, 17 Jul 2013, Diego Biurrun wrote:

---

The PPC bits are untested.  If somebody could compile that quickly..

Also, in the PPC parts I dropped some variable indirections.  There is
only ever going to be altivec there for acceleration.

Test built on PPC, built just fine.

libavcodec/ppc/hpeldsp_altivec.c       |    4 +--
libavcodec/x86/ac3dsp_init.c           |   20 ++++++------
libavcodec/x86/cavsdsp.c               |    8 ++---
libavcodec/x86/dsputil_init.c          |   52 ++++++++++++++++----------------
libavcodec/x86/dsputilenc_mmx.c        |   28 ++++++++---------
libavcodec/x86/fft_init.c              |   20 ++++++------
libavcodec/x86/fmtconvert_init.c       |   12 ++++----
libavcodec/x86/h264_intrapred_init.c   |   22 +++++++-------
libavcodec/x86/h264_qpel.c             |   12 ++++----
libavcodec/x86/h264chroma_init.c       |   16 +++++-----
libavcodec/x86/h264dsp_init.c          |   26 ++++++++--------
libavcodec/x86/hpeldsp_init.c          |   28 ++++++++---------
libavcodec/x86/lpc.c                   |    4 +--
libavcodec/x86/motion_est.c            |    8 ++---
libavcodec/x86/mpegaudiodsp.c          |   14 ++++-----
libavcodec/x86/mpegvideo.c             |    6 ++--
libavcodec/x86/mpegvideoenc.c          |   10 +++---
libavcodec/x86/pngdsp_init.c           |   10 +++---
libavcodec/x86/proresdsp_init.c        |    8 ++---
libavcodec/x86/rv34dsp_init.c          |    8 ++---
libavcodec/x86/rv40dsp_init.c          |   12 ++++----
libavcodec/x86/sbrdsp_init.c           |    6 ++--
libavcodec/x86/vc1dsp_init.c           |   18 +++++------
libavcodec/x86/videodsp_init.c         |   10 +++---
libavcodec/x86/vorbisdsp_init.c        |    6 ++--
libavcodec/x86/vp3dsp_init.c           |    8 ++---
libavcodec/x86/vp56dsp_init.c          |    6 ++--
libavcodec/x86/vp8dsp_init.c           |   16 +++++-----
libavfilter/x86/af_volume_init.c       |   10 +++---
libavresample/x86/audio_convert_init.c |   16 +++++-----
libavresample/x86/audio_mix_init.c     |   20 ++++++------
libavresample/x86/dither_init.c        |   12 ++++----
libavutil/ppc/float_dsp_init.c         |    4 +--
libavutil/x86/float_dsp_init.c         |   12 ++++----
34 files changed, 235 insertions(+), 237 deletions(-)

diff --git a/libavcodec/x86/dsputilenc_mmx.c b/libavcodec/x86/dsputilenc_mmx.c
index 8537f7a..e8cd3c6 100644
--- a/libavcodec/x86/dsputilenc_mmx.c
+++ b/libavcodec/x86/dsputilenc_mmx.c
        const int dct_algo = avctx->dct_algo;
        if (avctx->bits_per_raw_sample <= 8 &&
            (dct_algo==FF_DCT_AUTO || dct_algo==FF_DCT_MMX)) {
-            if(mm_flags & AV_CPU_FLAG_SSE2){
+            if(cpu_flags & AV_CPU_FLAG_SSE2){

Please add spacing while you're touching these lines

                c->fdct = ff_fdct_sse2;
-            } else if (mm_flags & AV_CPU_FLAG_MMXEXT) {
+            } else if (cpu_flags & AV_CPU_FLAG_MMXEXT) {
                c->fdct = ff_fdct_mmxext;
            }else{
                c->fdct = ff_fdct_mmx;
@@ -998,7 +998,7 @@ av_cold void ff_dsputilenc_init_mmx(DSPContext *c, 
AVCodecContext *avctx)

        c->ssd_int8_vs_int16 = ssd_int8_vs_int16_mmx;

-        if (mm_flags & AV_CPU_FLAG_MMXEXT) {
+        if (cpu_flags & AV_CPU_FLAG_MMXEXT) {

Ditto here and below a few more times in the same file

The rest of the patch looks good, no need to resend just for these details.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to