On Saturday, July 27, 2013, Diego Biurrun wrote:

> On Thu, Jul 25, 2013 at 06:08:03PM +0200, Luca Barbato wrote:
> > On 25/07/13 14:06, Diego Biurrun wrote:
> > > --- a/libavformat/flvdec.c
> > > +++ b/libavformat/flvdec.c
> > > @@ -125,8 +125,6 @@ static int flv_same_audio_codec(AVCodecContext
> *acodec, int flags)
> > >      default:
> > >          return acodec->codec_tag == (flv_codecid >>
> FLV_AUDIO_CODECID_OFFSET);
> > >      }
> > > -
> > > -    return 0;
> > >  }
> >
> > Those above are safer to be left.
>
> There's a big switch with a return in every case.  If another case w/o
> return is added, there will be a warning.  I don't see a problem.
>

Warnings have a tendency of being ignored, however...
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to