On Wednesday, July 31, 2013, Diego Biurrun wrote:
> From: Vittorio Giovara <[email protected] <javascript:;>>
>
> Signed-off-by: Diego Biurrun <[email protected] <javascript:;>>
> ---
> h->sei_recovery_frame_cnt = -1;
> h->sei_dpb_output_delay = 0;
> h->sei_cpb_removal_delay = -1;
> h->sei_buffering_period_present = 0;
>
Just a note, in other places we align at = only, without aligning the
numbers with negative sign.
However I like this formatting more, so I'd suggest to leave it like this
> - do{
> - type+= show_bits(&h->gb, 8);
> - }while(get_bits(&h->gb, 8) == 255);
> + do
> + type += show_bits(&h->gb, 8);
> + while (get_bits(&h->gb, 8) == 255);
>
> - size=0;
> - do{
> - size+= show_bits(&h->gb, 8);
> - }while(get_bits(&h->gb, 8) == 255);
> + do
> + size += show_bits(&h->gb, 8);
> + while (get_bits(&h->gb, 8) == 255);
>
>
I'm not sure, even if one liners I like the curly braces for do clauses,
IMHO it makes them more spottable.
OK for the rest.
Viyyorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel