On Mon, Sep 23, 2013 at 4:44 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Mon, Sep 23, 2013 at 04:34:25AM -0400, Alex Smith wrote: >> Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now >> works again passing all fate tests for version icl version 14. > > s/version// > >> Qansi-alias is the icl equivalent of -fstrict-aliasing. > > IMO redundant.
Well you asked as if it wasn't clear from the context. > >> --- a/configure >> +++ b/configure >> @@ -4021,8 +4021,9 @@ elif enabled_any msvc icl; then >> if enabled icl; then >> - # basically -fstrict-aliasing that does not work (correctly) on icl >> 13.x >> - check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags >> -Qansi-alias >> + # -Qansi-alias is basically -fstrict-aliasing that does not work >> (correctly) on icl 13.x > > Break this line. What do you mean by that? > >> + check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags >> -Qansi-alias >> + check_cpp_condition "windows.h" "__ICL >= 1400" && add_cflags >> -Qansi-alias > > Can't you check for "== 13" in just one line? > > Diego No, __ICL is the compiler version which is defined as VRP (version, revision, patch) so as updates roll out it won't stay the same. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
