On Wed, Oct 02, 2013 at 03:39:10PM +0200, Vittorio Giovara wrote:
> --- a/Changelog
> +++ b/Changelog
> @@ -115,6 +115,7 @@ version 9_beta1:
> - Opus decoder and encoder using libopus
> - remove -same_quant, it hasn't worked for years
> - support for building with MSVC
> +- Opus native parser
I think "parser" does not convey much information here.
Opus in Ogg demuxing
should be better.
> --- a/libavformat/oggdec.c
> +++ b/libavformat/oggdec.c
> @@ -46,6 +46,7 @@ static const struct ogg_codec * const ogg_codecs[] = {
> &ff_theora_codec,
> &ff_flac_codec,
> &ff_celt_codec,
> + &ff_opus_codec,
> &ff_old_dirac_codec,
> &ff_old_flac_codec,
> &ff_ogm_video_codec,
Do we care about ABI compatibility in such arrays?
> --- /dev/null
> +++ b/libavformat/oggparseopus.c
> @@ -0,0 +1,142 @@
> +/*
> + * Opus parser for Ogg
> + * Copyright (c) 2012 Nicolas George
nit: empty line between description and copyright statement
> + if (os->psize < OPUS_HEAD_SIZE || (AV_RL8(packet + 8) & 0xF0) != 0)
nit: I'd drop parentheses here.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
