oh i see, we miscommunicated :-)

yes, setting CC here is not important at all, you could override it
but whatever.

Regarding the use pkg-config, I also had this thought, but decided
against it because you might not have it installed on your system.

In any case, you can override LDLIBS on the command line:

make LDLIBS=`pkg-config --static --libs libavformat libavcodec
libavutil vo-aacenc`

What about we put this invocation suggestion as comment at the top of
the makefile, and leave the explicit line as it is?

Best,
Reinhard

On Thu, Oct 10, 2013 at 8:53 PM, Luca Barbato <[email protected]> wrote:
> On 11/10/13 02:02, Reinhard Tartler wrote:
>> On Thu, Oct 10, 2013 at 11:09 AM, Luca Barbato <[email protected]> wrote:
>>> On 10/10/13 16:43, Reinhard Tartler wrote:
>>>> On Wed, Oct 9, 2013 at 4:41 PM, Anton Khirnov <[email protected]> wrote:
>>>>> From: Andreas Unterweger <[email protected]>
>>>>>
>>>>> Signed-off-by: Anton Khirnov <[email protected]>
>>>>> ---
>>>>> Added some fixes, mostly cosmetics, but also some functional (using
>>>>> frame->nb_samples instead of codec context frame size, which might not be
>>>>> constant, or known at all; only write output packet it the encoder 
>>>>> actually
>>>>> returned it).
>>>>>
>>>>> A certain Diego should also help us with integrating this with the build 
>>>>> system.
>>>>> ---
>>>>>  doc/examples/Makefile  |   15 +
>>>>>  doc/examples/mp3_aac.c |  722 
>>>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>>>  2 files changed, 737 insertions(+)
>>>>>  create mode 100644 doc/examples/Makefile
>>>>>  create mode 100644 doc/examples/mp3_aac.c
>>>>>
>>>>> diff --git a/doc/examples/Makefile b/doc/examples/Makefile
>>>>> new file mode 100644
>>>>> index 0000000..ddc53bb
>>>>> --- /dev/null
>>>>> +++ b/doc/examples/Makefile
>>>>> @@ -0,0 +1,15 @@
>>>>> +CC=gcc
>>>>> +
>>>>> +CFLAGS=-c -Wall
>>>>> +LDFLAGS=-lavformat -lavcodec -lavresample -lavutil -lvo-aacenc -lpthread 
>>>>> -lm
>>>>> +
>>>>> +all: mp3_to_aac
>>>>> +
>>>>> +mp3_to_aac: mp3_aac
>>>>> +       $(CC) mp3_aac.o -o mp3_to_aac.exe $(LDFLAGS)
>>>>> +
>>>>> +mp3_aac: mp3_aac.c
>>>>> +       $(CC) $(CFLAGS) mp3_aac.c
>>>>> +
>>>>> +clean:
>>>>> +       rm -rf *.o *.exe
>>>>
>>>>
>>>> What about this makefile:
>>>>
>>>> CC=gcc
>>>
>>> better leave it as is.
>>
>> Why? The original version cannot be made to work with a copy of
>> libavcodec not installed in standard search path locations without
>> modifcation. My version is simple, and I've shown instructions how to
>> use it with non-standard locations. I think this is important because
>> it helps with testing the latest HEAD of a branch.
>
> Meant CC left as the default =)
>
> lu
>
> _______________________________________________
> libav-devel mailing list
> [email protected]
> https://lists.libav.org/mailman/listinfo/libav-devel



-- 
regards,
    Reinhard
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to