On Sun, Oct 27, 2013 at 1:17 PM, Anton Khirnov <an...@khirnov.net> wrote:
> It's a private field, not meant to be accessed from outside lavc.
> ---
> libavcodec/avcodec.h | 8 +++-----
> libavcodec/internal.h | 6 ++++++
> libavcodec/pthread_frame.c | 2 +-
> libavcodec/rawdec.c | 3 ++-
> libavcodec/utils.c | 8 ++++----
> libavcodec/version.h | 3 +++
> 6 files changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index f5464d0..8ab2ebc 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -2662,14 +2662,12 @@ typedef struct AVCodecContext {
> */
> int error_rate;
>
> +#if FF_API_CODEC_PKT
> /**
> - * Current packet as passed into the decoder, to avoid having
> - * to pass the packet into every function. Currently only valid
> - * inside lavc and get/release_buffer callbacks.
> - * - decoding: set by avcodec_decode_*, read by get_buffer() for setting
> pkt_pts
> - * - encoding: unused
> + * @deprecated this field is not supposed to be accessed from outside
> lavc
> */
> AVPacket *pkt;
> +#endif
I think there could be a deprecated attribute here
>
> /**
> * VBV delay coded in the last frame (in periods of a 27 MHz clock).
> diff --git a/libavcodec/internal.h b/libavcodec/internal.h
> index 9a57209..4648c02 100644
> --- a/libavcodec/internal.h
> +++ b/libavcodec/internal.h
> @@ -88,6 +88,12 @@ typedef struct AVCodecInternal {
> FramePool *pool;
>
> void *thread_ctx;
> +
> + /**
> + * Current packet as passed into the decoder, to avoid having to pass the
> + * packet into every function.
> + */
> + AVPacket *pkt;
> } AVCodecInternal;
Since this is an internal struct there is no need of bump, right?
>
> struct AVCodecDefault {
The rest seems ok
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
