---
Hi, I think I was able to remove the -wN flag warning on OSX, but then a new 
error popped out:

YASM    libavcodec/x86/h264_deblock_10bit.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip:
 symbols referenced by relocation entries that can't be stripped in: 
libav/libavcodec/x86/h264_deblock_10bit.o
_ff_pw_4
pw_pixel_max
_ff_pw_2
_ff_pw_3

Searching for that error results in a reference to osx's strip manpage that 
says:

strip no longer removes relocation entries under any condition. Instead, it 
updates the external relocation entries (and indirect symbol table entries) to 
reflect the resulting symbol table. strip prints an error message for those 
symbols not in the resulting symbol table that are needed by an external 
relocation entry or an indirect symbol table. The link editor ld(1) is the only 
program that can strip relocation entries and know if it is safe to do so.

I intuitevely added the -x option which apparently fixed this for me, although 
it might alter the original intent of the -wN flags completely. Maybe the right 
way would be not to use strip at all on OSX?
Any suggestion is welcome.
Vittorio

 configure   | 19 +++++++++++++++++++
 library.mak |  2 +-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 88e7058..cf599e1 100755
--- a/configure
+++ b/configure
@@ -659,6 +659,10 @@ add_ldflags(){
     append LDFLAGS $($ldflags_filter "$@")
 }
 
+add_stripflags(){
+    append STRIPFLAGS "$@"
+}
+
 add_extralibs(){
     prepend extralibs $($ldflags_filter "$@")
 }
@@ -804,6 +808,16 @@ check_ldflags(){
     test_ldflags "$@" && add_ldflags "$@"
 }
 
+test_stripflags(){
+    log test_stripflags "$@"
+    check_cmd $strip $STRIPFLAGS "$@" $TMPO
+}
+
+check_stripflags(){
+    log check_stripflags "$@"
+    test_stripflags "$@" && add_stripflags "$@"
+}
+
 check_header(){
     log check_header "$@"
     header=$1
@@ -3930,6 +3944,10 @@ check_ldflags -Wl,--warn-common
 check_ldflags 
-Wl,-rpath-link=libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample
 test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic
 
+# add some strip flags
+check_stripflags -wN '..@*'
+check_stripflags -x
+
 enabled xmm_clobber_test &&
     check_ldflags -Wl,--wrap,avcodec_open2              \
                   -Wl,--wrap,avcodec_decode_audio4      \
@@ -4205,6 +4223,7 @@ LD_PATH=$LD_PATH
 DLLTOOL=$dlltool
 LDFLAGS=$LDFLAGS
 SHFLAGS=$(echo $($ldflags_filter $SHFLAGS))
+STRIPFLAGS=$STRIPFLAGS
 YASMFLAGS=$YASMFLAGS
 BUILDSUF=$build_suffix
 FULLNAME=$FULLNAME
diff --git a/library.mak b/library.mak
index 7292c8a..3876fe3 100644
--- a/library.mak
+++ b/library.mak
@@ -25,7 +25,7 @@ $(SUBDIR)%-test.i: $(SUBDIR)%.c
 $(SUBDIR)x86/%.o: $(SUBDIR)x86/%.asm
        $(DEPYASM) $(YASMFLAGS) -I $(<D)/ -M -o $@ $< > $(@:.o=.d)
        $(YASM) $(YASMFLAGS) -I $(<D)/ -o $@ $<
-       -$(STRIP) -wN '..@*' $@
+       -$(STRIP) $(STRIPFLAGS) $@
 
 LIBOBJS := $(OBJS) $(SUBDIR)%.h.o $(TESTOBJS)
 $(LIBOBJS) $(LIBOBJS:.o=.i):   CPPFLAGS += -DHAVE_AV_CONFIG_H
-- 
1.8.4

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to