On 9/9/2013 6:38 PM, Kostya Shishkov wrote:
> This is essentially a MS GSM decoder extension that supports more
> sampling rates and lower bitrates.
> ---
[...]
> + if (!avctx->block_align)
> + avctx->block_align = GSM_MS_BLOCK_SIZE;
> + else
> + if (avctx->block_align < MSN_MIN_BLOCK_SIZE ||
> + avctx->block_align > GSM_MS_BLOCK_SIZE ||
> + (avctx->block_align - MSN_MIN_BLOCK_SIZE) % 3) {
> + av_log(avctx, AV_LOG_ERROR, "Invalid block alignment %d\n",
> + avctx->block_align);
> + return AVERROR_INVALIDDATA;
> + }
> }
Tiny tiny inconsequential nit: Braces would make it a bit easier to discern
what goes where.
> + for (i = 0; i < 13; i++) {
> + val = get_bits(gb, frame_bits[i]);
> + dst[3*i] += tab[requant_tab[frame_bits[i]][val]];
> + }
Someone will complain about alignment.
Functionally LGTM.
- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
