On 12/11/13 01:21, Reinhard Tartler wrote: > On Tue, Dec 10, 2013 at 4:51 PM, Diego Biurrun <[email protected]> wrote: >> On Tue, Dec 10, 2013 at 10:46:52PM +0100, Luca Barbato wrote: >>> On 10/12/13 21:31, Vittorio Giovara wrote: >>>> On Tuesday, December 10, 2013, Luca Barbato wrote: >>>>> On 10/12/13 15:28, Vittorio Giovara wrote: >>>>>> --- a/libavformat/mpegts.c >>>>>> +++ b/libavformat/mpegts.c >>>>>> @@ -570,6 +570,7 @@ static const StreamType REGD_types[] = { >>>>>> { MKTAG('D','T','S','1'), AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_DTS }, >>>>>> { MKTAG('D','T','S','2'), AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_DTS }, >>>>>> { MKTAG('D','T','S','3'), AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_DTS }, >>>>>> + { MKTAG('H','E','V','C'), AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_HEVC }, >>>>>> { MKTAG('V','C','-','1'), AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_VC1 }, >>>>>> { 0 }, >>>>>> }; >>>>> >>>>> Vertical alignment please. >>>> >>>> The codec ids are aligned at the }, see the whole file. I got tricked by it >>>> too when I first saw this :-) >>>> Vittorio >>> >>> That doesn't make it less wrong. =/ >> >> Just leave as-is IMO. > > Does this comment refer to the style or the actual change, i.e., does > the change the right thing and only the formatting is wrong, or what > else is wrong?
The patch can get in IMHO (better if we have a sample of this around in case). The file could enjoy a restyle. That reminds me that tentatively the cleanup sprint should happen before fosdem (the weekend before?). lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
