On 09/01/14 01:36, Sean McGovern wrote: > On Thu, Oct 10, 2013 at 3:03 PM, Luca Barbato <[email protected]> wrote: > >> Sample-Id: 00000611-google >> >> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind >> CC: [email protected] >> --- >> libavcodec/proresdec.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavcodec/proresdec.c b/libavcodec/proresdec.c >> index c65d729..144fa26 100644 >> --- a/libavcodec/proresdec.c >> +++ b/libavcodec/proresdec.c >> @@ -393,12 +393,16 @@ static inline int decode_ac_coeffs(GetBitContext >> *gb, int16_t *out, >> return 0; >> >> run = decode_vlc_codeword(gb, >> ff_prores_ac_codebook[run_cb_index]); >> + if (run < 0) >> + return AVERROR_INVALIDDATA; >> >> bits_left = get_bits_left(gb); >> if (bits_left <= 0 || (bits_left <= 8 && !show_bits(gb, >> bits_left))) >> return AVERROR_INVALIDDATA; >> >> level = decode_vlc_codeword(gb, >> ff_prores_ac_codebook[lev_cb_index]) + 1; >> + if (level < 0) >> + return AVERROR_INVALIDDATA; >> >> pos += run + 1; >> if (pos >= max_coeffs) >> -- >> > > Hi, > > Just a heads up that this commit broke all the prores tests on release/9. > Verified both on my Solaris 11.1 box and on a PowerPC Linux machine.
Would be interesting see why it didn't break it on master. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
