On Sat, Feb 08, 2014 at 11:52:19AM +0100, Janne Grunau wrote:
> Fixes compilation with MSVC. Also does not rely on on earlier config.h
> include but include it directly.

on on?

May I suggest Oracle, which has an MSVC instance on it?

> --- a/libavcodec/x86/dca.h
> +++ b/libavcodec/x86/dca.h
> @@ -18,7 +18,9 @@
>  
> -#if ARCH_X86_64
> +#include "config.h"
> +
> +#if ARCH_X86_64 && HAVE_SSE2_INLINE
>  # include "libavutil/x86/asm.h"
>  # include "libavutil/mem.h"
>  
> @@ -49,4 +51,4 @@ static inline void int8x8_fmul_int32(av_unused 
> DCADSPContext *dsp,
>  
> -#endif /* ARCH_X86_64 */
> +#endif /* ARCH_X86_64 && HAVE_SSE2_INLINE */

This looks wrong.  In all other places we protect MSVC with HAVE_INLINE_ASM
against inline assembly, why suddenly so specific here?

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to