On Thu, Feb 13, 2014 at 9:11 PM, Derek Buitenhuis <[email protected]> wrote: > On 2/13/2014 6:59 PM, Jan Ekström wrote: >> The official Ut Video encoder only threads with slices, thus until >> now any files encoded by the libavcodec encoder have only been >> decode'able with a single thread. The default slice count is now > ~~~~~~~~~~~ > ^-- decodable
Done. >> Also sets slices to 1 for the Ut Video encoder tests to keep them >> green. > > Add some slice tests too?~ Maybe in the future? I actually tested it against the official decoder on a subsampled_height = 8 && slices = 8 kind of setup, and I got a bit-exact result so it seems to work. >> + /* Check the asked slice count for obviously invalid values (> 256 or >> negative) */ > > /* > * Check the asked slice count for obviously invalid > * values (> 256 or negative). > */ Done. > Why not make it a warning and use: > > av_clip_uint8(avctx->slices) Because [0,256] is the valid range, not [0,255]? > Diego-nit: Braces for consistency Braces added. Thanks for the review :) Jan Ekström _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
