On 06 Feb 2014, at 22:37, Tim Walker <[email protected]> wrote:

> ---
> 
> This is pretty AC3-centric, but using abosulte scale factors rather than dB
> levels (or worse, indexes/codes) should make it compatible with other codecs
> should they implement a similar kind of downmix metadata.
> 
> Justin suggested making even more codec-agnostic by using flags to indicate
> the precense or absence of certain fields, but I'm unsure as to how this could
> be implemented. Any ides or examples?
> 
> doc/APIchanges      | 4 ++++
> libavutil/Makefile  | 2 ++
> libavutil/frame.h   | 5 +++++
> libavutil/version.h | 2 +-
> 4 files changed, 12 insertions(+), 1 deletion(-)

Ping.

Still unsure on how to use flags with this. Something like:

if (flags & LTRT_SOME_FLAG)
{
    // center_mix_level_ltrt, surround_mix_level_ltrt are set and can be used
}
else
{
    // ignore center_mix_level_ltrt, surround_mix_level_ltrt, they are unset
    // please use your own defaults
}

…seems a bit silly, when the fields can just be set to a sane default (which 
may be specified in the spec., e.g. A/52). But YMMV.

Any opinions or ideas, or should this be left as-is?

I'd like it if this could make the cut for libav10.

Tim
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to