On Wed, 19 Feb 2014, Diego Biurrun wrote:
Also add warning comment about threading implementations without matching atomics implementation to the atomics fallback implementation. --- configure | 1 + libavutil/atomic.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-)diff --git a/configure b/configure index 292da47..841c39a 100755 --- a/configure +++ b/configure @@ -1606,6 +1606,7 @@ atomics_gcc_if="sync_val_compare_and_swap" atomics_suncc_if="atomic_cas_ptr machine_rw_barrier" atomics_win32_if="MemoryBarrier" atomics_native_if_any="$ATOMICS_LIST" +w32threads_deps="atomics_native" threads_if_any="$THREADS_LIST" # subsystems diff --git a/libavutil/atomic.c b/libavutil/atomic.c index e4fa957..cae63fc 100644 --- a/libavutil/atomic.c +++ b/libavutil/atomic.c @@ -97,8 +97,10 @@ void *avpriv_atomic_ptr_cas(void * volatile *ptr, void *oldval, void *newval) return *ptr; } -#else +#else /* HAVE_THREADS */ +/* This should never trigger, unless a new threading implementation + * without corresponding atomics implementation is added. */
"atomics implementation or dependency on atomics_native within configure" or something similar?
Except for that, it looks ok to me. // Martin _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
