On Wed, Feb 19, 2014 at 9:16 PM, Anton Khirnov <an...@khirnov.net> wrote:
> ---
> libavfilter/af_ashowinfo.c | 91
> ++++++++++++++++++++++++++++++++++++++++++++
> libavfilter/vf_showinfo.c | 54 ++++++++++++++++++++++++++
> 2 files changed, 145 insertions(+)
Nice, I'd recommend these tags for the stereo3d part:
> + av_log(ctx, AV_LOG_INFO, "type - ");
> + switch (stereo->type) {
> + case AV_STEREO3D_2D: av_log(ctx, AV_LOG_INFO, "2D");
> break;
> + case AV_STEREO3D_SIDEBYSIDE: av_log(ctx, AV_LOG_INFO, "side by
> side"); break;
> + case AV_STEREO3D_TOPBOTTOM: av_log(ctx, AV_LOG_INFO,
> "top/bottom"); break;
top and bottom
> + case AV_STEREO3D_FRAMESEQUENCE: av_log(ctx, AV_LOG_INFO, "frame
> sequence"); break;
frame alternate
> + case AV_STEREO3D_CHECKERBOARD: av_log(ctx, AV_LOG_INFO,
> "checkerboard"); break;
> + case AV_STEREO3D_LINES: av_log(ctx, AV_LOG_INFO,
> "interleaved lines"); break;
> + case AV_STEREO3D_COLUMNS: av_log(ctx, AV_LOG_INFO,
> "interleaved columns"); break;
> + case AV_STEREO3D_SIDEBYSIDE_QUINCUNX: av_log(ctx, AV_LOG_INFO, "side by
> side quincunx"); break;
side by side (quincunx subsampling)
I think i'd promote the "unknown" fields with a AV_LOG_WARNING so that
it's easier to spot missing values when adding new side data.
For example here
> + default: av_log(ctx, AV_LOG_INFO,
> "unknown"); break;
> + }
and here
> + default:
> + av_log(ctx, AV_LOG_INFO, "unknown side data type %d (%d bytes)",
> + sd->type, sd->size);
> + break;
> + }
> +
> + av_log(ctx, AV_LOG_INFO, "\n");
> + }
> +
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
