On 2014-03-05 15:25:40 +0100, Anton Khirnov wrote:
>
> On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles <justin.rugg...@gmail.com>
> wrote:
> > On 03/05/2014 04:43 AM, Luca Barbato wrote:
> > > diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c
> > > index 12d496e..2cdfe23 100644
> > > --- a/libavfilter/af_volume.c
> > > +++ b/libavfilter/af_volume.c
> > > @@ -262,6 +262,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame
> > > *buf)
> > > vol->scale_samples(out_buf->extended_data[p],
> > > buf->extended_data[p], plane_samples,
> > > vol->volume_i);
> > > + emms_c();
> > > }
> > > } else if (av_get_packed_sample_fmt(vol->sample_fmt) ==
> > > AV_SAMPLE_FMT_FLT) {
> > > for (p = 0; p < vol->planes; p++) {
> >
> > Neither of the dsp functions used in af_volume utilize MMX registers.
> > Adding emms_c() is completely pointless.
> >
>
> That requires the caller to know this.
>
> And we might add such functions in the future (unlikely, but still possible)
is there a reason we don't use the the libavcodec approach and just call
emms_c in ff_filter_frame?
Janne
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
