On Mon, Mar 10, 2014 at 10:33:27PM +0100, Vittorio Giovara wrote:
> --- /dev/null
> +++ b/libavcodec/mvcdec.c
> @@ -0,0 +1,287 @@
> +
> +#include "libavutil/intreadwrite.h"
> +#include "avcodec.h"
> +#include "bytestream.h"
> +#include "internal.h"
canonical spacing
> +#define PIX16(target, true, false) \
> + i = (mask & target) ? true : false; \
> + AV_WN16A(dst, (v[i] & 0x7C00) | (v[i] & 0x3E0) | (v[i] & 0x1F)); \
> + dst += 2;
> +
> +#define ROW16(row, a1, a0, b1, b0) \
> + dst = dst_start + (y + row) * linesize + x * 2; \
> + PIX16(1 << (row * 4), a1, a0) \
> + PIX16(1 << (row * 4 + 1), a1, a0) \
> + PIX16(1 << (row * 4 + 2), b1, b0) \
> + PIX16(1 << (row * 4 + 3), b1, b0)
nit: Align the \, same below.
> + if (x >= width) {
> + y += 4;
> + if (y >= height) {
> + break;
> + }
Drop {}.
> + if (bytestream2_get_byteu(gb)) {
> + avpriv_request_sample(avctx, "bitmap feature");
Capitalize "bitmap", it is the start of a sentence.
> +static int mvc_decode_frame(AVCodecContext *avctx,
> + void *data, int *got_frame,
> + AVPacket *avpkt)
Coalesce the lines.
Does the decoder compile standalone?
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
