On Wed, Mar 19, 2014 at 06:54:44PM +0100, Luca Barbato wrote: > On 19/03/14 18:34, Diego Biurrun wrote: > > --- > > > > Amended to not break some long lines for enhanced readability. > > Readability remains impaired. > > > +#define HPELDSP_AVG_PIXELS16(CPUEXT) \ > > + CALL_2X_PIXELS(put_no_rnd_pixels16_x2 ## CPUEXT, > > ff_put_no_rnd_pixels8_x2 ## CPUEXT, 8) \ > > + CALL_2X_PIXELS(put_pixels16_y2 ## CPUEXT, ff_put_pixels8_y2 > > ## CPUEXT, 8) \ > > + CALL_2X_PIXELS(put_no_rnd_pixels16_y2 ## CPUEXT, > > ff_put_no_rnd_pixels8_y2 ## CPUEXT, 8) \ > > + CALL_2X_PIXELS(avg_pixels16 ## CPUEXT, ff_avg_pixels8 > > ## CPUEXT, 8) \ > > + CALL_2X_PIXELS(avg_pixels16_x2 ## CPUEXT, ff_avg_pixels8_x2 > > ## CPUEXT, 8) \ > > + CALL_2X_PIXELS(avg_pixels16_y2 ## CPUEXT, ff_avg_pixels8_y2 > > ## CPUEXT, 8) \ > > + CALL_2X_PIXELS(avg_pixels16_xy2 ## CPUEXT, ff_avg_pixels8_xy2 > > ## CPUEXT, 8) > > > > --- a/libavcodec/x86/rnd_mmx.c > > +++ b/libavcodec/x86/rnd_mmx.c > > @@ -30,7 +31,7 @@ > > > > #include "rnd_template.c" > > > > -PIXELS16(, ff_avg, , _xy2, _mmx) > > -PIXELS16(, ff_put, , _xy2, _mmx) > > +CALL_2X_PIXELS_EXPORT(ff_avg_pixels16_xy2_mmx, ff_avg_pixels8_xy2_mmx, 8) > > +CALL_2X_PIXELS_EXPORT(ff_put_pixels16_xy2_mmx, ff_put_pixels8_xy2_mmx, 8) > > > > #endif /* HAVE_INLINE_ASM */ > > > > Do not replace PIXELS16. just implement PIXELS16 with CALL_2X_PIXELS_EXPORT.
I don't get your point. This patch is about unifying two duplicated macros: CALL_2X_PIXELS and PIXELS16. The former name is more descriptive, so I settled for it. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
