Diego Biurrun <[email protected]> writes: > On Thu, Jun 05, 2014 at 05:33:19PM +0200, Niels Möller wrote: >> >> Comments appreciated. I see no obvious way to split it in smaller >> independent pieces, but maybe someone else does. > > You could add the tables as a separate dummy commit. That should not break > anything and reduce the line count considerably.
That's basically the changes to dcadata.h. I could send that as a separate patch (and maybe take out the comment changes separately as well). > The TRACE_XLL bits can probably go away. Should I delete that code completely, or make it conditional on TRACE instead? > some stylistic remarks below Noted, thanks. >> --- a/libavcodec/dcadec.c >> +++ b/libavcodec/dcadec.c >> @@ -4,6 +4,8 @@ >> * Copyright (C) 2004 Benjamin Zores >> * Copyright (C) 2006 Benjamin Larsson >> * Copyright (C) 2007 Konstantin Shishkov >> + * Copyright (C) 2012 Paul B Mahol > > Which part is Paul's? In my tree, http://www.southpole.se/~nisse/libav.git, it's this change: commit 7513a9e1c17121e45ec669bf286d3c8e37a072c8 Author: Paul B Mahol <[email protected]> Date: Tue Feb 11 13:37:35 2014 +0100 dcadec: XLL support, wip dcedata.h: New table dca_sampling_freqs. dcedec.c: New xll-related state variables. New function dca_xll_decode_frame, called from dca_exss_parse_header. These changes copied from the ffmpeg branch at https://github.com/richardpl/FFmpeg/commits/xll The function dca_xll_decode_frame has since been renamed to dca_xll_decode_header, but the first part of that is still Paul's code. >> + * Copyright (C) 2014 Niels Möller > > Something is wrong with your UTF-8 setup. Right. I use utf-8 on most machines, but from lazyness I still use latin-1 on the machine where I run my mail client, and I forgot M-x universal-coding-system-argument when inserting the patch file. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
