On Fri, 6 Jun 2014 14:05:26 +0300, Martin Storsjö <[email protected]> wrote: > On big endian machines, the default value set via the faulty > AVOption ended up as 2^32 times too big. > > This fixes the fate-lavf-ogg test which currently is broken on > big endian machines, broken since 3831362. Since that commit, > a final zero-sized packet is written to the ogg muxer in that test, > which caused different flushing behaviour on little and big endian > depending on whether the pref_duration option was handled as it > should or not. > > CC: [email protected] > --- > libavformat/oggenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c > index 0d8e239..d148f5b 100644 > --- a/libavformat/oggenc.c > +++ b/libavformat/oggenc.c > @@ -80,7 +80,7 @@ static const AVOption options[] = { > { "pagesize", "preferred page size in bytes (deprecated)", > OFFSET(pref_size), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, MAX_PAGE_SIZE, > PARAM }, > { "page_duration", "preferred page duration, in microseconds", > - OFFSET(pref_duration), AV_OPT_TYPE_INT, { .i64 = 1000000 }, 0, > INT64_MAX, PARAM }, > + OFFSET(pref_duration), AV_OPT_TYPE_INT64, { .i64 = 1000000 }, 0, > INT64_MAX, PARAM }, > { NULL }, > }; > > -- > 1.8.5.2 (Apple Git-48) >
Looks ok Thanks for debugging this -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
