On Thu, Jul 17, 2014 at 11:14:16AM +0530, Nidhi Makhijani wrote:
> --- /dev/null
> +++ b/libavdevice/oss_audio.h
> @@ -0,0 +1,47 @@
> +
> +#define AUDIO_BLOCK_SIZE 4096

The define is still duplicated.

> +typedef struct AudioData {
> +} AudioData;

This name is too generic now that you move it to a header, make it OSSAudioData.

> +int oss_ff_audio_open(AVFormatContext *s1, int is_output,
> +                      const char *audio_device);
> +
> +int oss_ff_audio_close(AudioData *s);

This is not how you should prefix names, see

https://www.libav.org/developer.html#Naming-conventions

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to