On Tue, Jul 22, 2014 at 03:16:28PM +0200, epira...@gmail.com wrote: > --- /dev/null > +++ b/libavformat/icecast.c > @@ -0,0 +1,228 @@ > +static int icecast_open(URLContext *h, const char *uri, int flags) > +{ > + IcecastContext *s = h->priv_data; > + > + // Dict to set options that we pass to HTTP protocol
"to the", although the comment seems a bit redundant, as do many of the comments in this file. > + if (auth[0] != '\0') { > + int user_len; > + char *p = strchr(auth, ':'); > + if (p){ space between ) and { > + // Setting user and pass from URI > + if (s->user != NULL) > + av_free(s->user); unnecessary NULL check > + } else { > + // Setting user from URI > + if (s->user != NULL) > + av_free(s->user); same Maybe you can move this out of the if-else block since it's done in both branches. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel