On Tue, Jul 29, 2014 at 02:32:17PM +0100, Vittorio Giovara wrote: > --- a/tests/fate/image.mak > +++ b/tests/fate/image.mak > @@ -59,6 +59,16 @@ fate-pictor: CMD = framecrc -i > $(TARGET_SAMPLES)/pictor/MFISH.PIC -pix_fmt rgb24 > > +define FATE_IMGSUITE_PNG > +FATE_SAMPLES_AVCONV-$(call DEMDEC, IMAGE2, PNG) += fate-png-$(1) > +fate-png-$(1): CMD = framecrc -i $(TARGET_SAMPLES)/png1/libav_$(1).png > -pix_fmt rgba > +FATE_PNG += fate-png-$(1) > +endef > + > +fate-png: $(FATE_PNG)
This will unconditionally add all targets to fate-png, even if the dependencies are not met. Collect them in a FATE_PNG variable instead and conditionally add that wherever necessary. > +IMGSUITE_PNG = gray8 gray16 ya8 ya16 rgb24 rgb48 rgba Is there a reason for non-alphabetical order here? > +$(foreach CLSP,$(IMGSUITE_PNG),$(eval $(call FATE_IMGSUITE_PNG,$(CLSP)))) I believe PNG_COLORSPACES is a better variable name than IMGSUITE_PNG. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
