On 11/07/14 16:40, Vittorio Giovara wrote:
> On Fri, Jul 11, 2014 at 8:24 AM, Luca Barbato <lu_z...@gentoo.org> wrote:
>> It should provide a quicker guess for elementary streams provided
>> by http.
>> ---
>> libavformat/avformat.h | 10 ++++++++++
>> libavformat/format.c | 34 ++++++++++++++++++++++------------
>> libavformat/version.h | 4 ++++
>> 3 files changed, 36 insertions(+), 12 deletions(-)
>
> I believe this should be before 3/5 and 4/5 because you add the new field
> here.
>
>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
>> index 2bc1df9..31ae84b 100644
>> --- a/libavformat/avformat.h
>> +++ b/libavformat/avformat.h
>> @@ -391,6 +391,9 @@ typedef struct AVProbeData {
>> const char *filename;
>> unsigned char *buf; /**< Buffer must have AVPROBE_PADDING_SIZE of extra
>> allocated bytes filled with zero. */
>> int buf_size; /**< Size of buf except extra allocated bytes */
>> +#ifdef FF_API_PROBE_MIME
>> + uint8_t *mime_type; /**< mime_type, when known. */
>> +#endif
>> } AVProbeData;
>>
>> #define AVPROBE_SCORE_EXTENSION 50 ///< score for file extension
>> @@ -535,6 +538,13 @@ typedef struct AVInputFormat {
>>
>> const AVClass *priv_class; ///< AVClass for the private context
>>
>> + /**
>> + * Comma-separated list of mime types.
>> + * It is used check for matching mime types while probing.
>> + * @see av_probe_input_format2
>> + */
>> + const char *mime_type;
>> +
>
> Also this should be ifdeffed with FF_API_PROBE_MIME because it's a public
> type.
>
But the struct is never used on stack.
lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
