On Tue, Jul 29, 2014 at 09:41:12PM +0530, Nidhi Makhijani wrote:
> --- a/libavcodec/mpeg4video.h
> +++ b/libavcodec/mpeg4video.h
> @@ -29,7 +29,7 @@
>
> -// shapes
> +/* shapes */
> #define RECT_SHAPE 0
> #define BIN_SHAPE 1
> @@ -43,11 +43,9 @@
> #define ACE_VO_TYPE 12
> -// aspect_ratio_info
> -#define EXTENDED_PAR 15
> +#define EXTENDED_PAR 15 ///< aspect_ratio_info
>
> -//vol_sprite_usage / sprite_enable
> -#define STATIC_SPRITE 1
> +#define STATIC_SPRITE 1 ///< vol_sprite_usage / sprite_enable
> #define GMC_SPRITE 2
Let's leave non-Doxygen comments as-is.
> @@ -62,38 +60,31 @@
> typedef struct Mpeg4DecContext {
> MpegEncContext m;
>
> - ///< number of bits to represent the fractional part of time
> - int time_increment_bits;
> + int time_increment_bits; ///< number of bits to represent the fractional
> part of time
Nah, keep the comments above the struct members, we only get absurdly long
lines otherwise. Just change the syntax so that the correct member is
documented.
Also, many of those comments are written in Engrish. Let's try to
improve them while you're at it.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
